使用Rails best practices做代码审查

rails_best_practices

ﬂyerhzm@gmail.com

Proprietary and Conﬁden/al. © 2010 Aurora Feint. 1

•  a.k.a Richard Huang
• hDp://huangzhimin.com
• hDp://twiDer.com/ﬂyerhzm
• hDp://github.com/ﬂyerhzm

• OpenFeint


rails_best_practices gem

• rails
• 24
•
•


rails-bestpractices.com

•
• 63
• gem
• gem


rails

•
•
•


Java
• checkstyle


Ruby

• Saikuro ‐ 
• Flog ‐ 
• Flay ‐ 
• Reek ‐  code smell



• rails
check list


rails_best_practice gem


rbp gem sexp

Proprietary and Conﬁden/al. © 2010 Aurora Feint.

sexp
class Post < ActiveRecord::Base
attr_accessor :editable
end

s(:class, :Post,
s(:colon2, s(:const, :ActiveRecord), :Base),
s(:scope,
s(:call, nil, :attr_accessor,
s(:arglist, s(:lit, :editable))
)
)
)


sexp
def test
puts "hello world"
end

s(:defn, :test, s(:args),
s(:scope,
s(:block,
s(:call, nil, :puts,
s(:arglist, s(:str, "hello world"))
)
)
)
)


if i > 10
puts "more than ten"
else
puts "less than or equal to ten"
end

s(:if,
s(:call,
s(:call, nil, :i, s(:arglist)),
:>,
s(:arglist, s(:lit, 10))
),
s(:arglist, s(:str, "more than ten"))
),
s(:arglist, s(:str, "less than or equal to ten"))
)
)


Play with sexp

ruby_parser


•
• trailing white space
• tab spaces


(prepare)

•
• models

• model associa/ons

• model aDributes

• mailers


(review)

•
• use model virtual aDribute
• use query aDribute
• always add db index
• ......


Demo


• diaspora   github rails

• rails_best_prac/ces diaspora


• rails_best_prac/ces
• rails_best_prac/ces ‐‐format html
• rails_best_prac/ces ‐f html ‐‐with‐textmate
• rails_best_prac/ces ‐f html ‐‐with‐mvim


• rails_best_prac/ces ‐g
• mvim conﬁg/rails_best_prac/ces.yml


How to write your own check list?


• rails best prac/ces 
hDp://rails‐bestprac/ces.com/ 
hDps://github.com/ﬂyerhzm/rails_best_prac/ces
hDp://rdoc.rails‐bestprac/ces.com/

03/23/11 Proprietary and Conﬁden/al. © 2010 Aurora Feint. 26

OpenFeint

• mobile game social network 
( 7 )

•
•
• mailto: hr@openfeint.cn


使用Rails best practices做代码审查

Recommandé

Recommandé

Contenu connexe

En vedette

En vedette (12)

Similaire à 使用Rails best practices做代码审查

Similaire à 使用Rails best practices做代码审查 (20)

Plus de Richard Huang

Plus de Richard Huang (8)

Dernier

Dernier (20)

使用Rails best practices做代码审查

Notes de l'éditeur