Proposed a name for the code smell that looks like the intra-class version of Shotgun Surgery

1. Better Code Smell
Fragmenting Bullet
Intra-class coupling
One fragmenting bullet hitting N functions in one class
Code smell name coined by Philip Schwarz
@philip_schwarz
Worse Code Smell
Shotgun Surgery
Inter-class coupling
N pellets each hitting a function in a different class
Martin’s Fowler’s code smell – http://refactoring.com/
@martinfowler
So, cohesion is coupling within an element. It is better to have coupling spanning smaller distance(e.g. if I have to change two functions that are adjacent in a
source file, that's better than having to change two functions in two different source files).
@KentBeck
in https://www.quora.com/Is-it-true-that-whenever-I-increase-cohesion-of-design-coupling-in-the-design-would-automatically-decrease
Shotgun Surgery
Shotgun surgery is similar to divergent change but is the opposite. You
whiff this when every time you make a kind of change, you have to make a
lot of little changes to a lot of different classes. When the changes are all
over the place, they are hard to find, and it's easy to miss an important
change.
In this case you want to use Move Method and Move Field to put all the
changes into a single class. If no current class looks like a good candidate,
create one. Often you can use Inline Class to bring a whole bunch of
behavior together. You get a small dose of divergent change, but you can
easilydeal withthat.
Divergent change is one class that suffers many kinds of changes,
and shotgun surgery is one change that alters many classes. Either way you
want to arrange things so that, ideally, there is a one-to-one link between
common changes and classes.
Martin Fowler in his book, Refactoring: Improving the Design of Existing
Code (1999) http://refactoring.com/
Coupling between A and B is defined as "if I change element A I also have to change element B". Cohesion of an element A is defined as "if I change subelement A.1, do I have
to change all the other subelements A.2-n?" So, cohesion is coupling within an element. It is better to have coupling spanning smaller distance (e.g. if I have to
change two functions that are adjacent in a source file,that's better than having to change two functions in two different source files).
Kent Beck in https://www.quora.com/Is-it-true-that-whenever-I-increase-cohesion-of-design-coupling-in-the-design-would-automatically-decrease