PyGotham 2015 Many developers see code review as a way to keep code compliant and to reduce bugs, but code review can be so much more than that! In this talk, I’ll share how reviewing code became one of the most valuable ways for me to become a better programmer. I’ll cover how you can learn more from code review, how you can improve your skills as a reviewer, and how to influence your colleagues to give you better code review. https://pygotham.org/2015/talks/215/how-reviewing-code-makes/

1. How$reviewing$code
makes&me&a&be(er&programmer!
Amy$Hanlon
@amygdalama

5. receive&be(er&reviews
become&a&be(er&reviewer
get$more$value$out$of$code$review

6. Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4. ✨+ask+clarifying+ques=ons+✨
5. ✨+offer+sugges=ons+✨

7. Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4. ✨+ask+clarifying+ques=ons+✨
5. ✨+offer+sugges=ons+✨

8. give%context

10. make%small%changes

11. Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4. ✨+ask+clarifying+ques=ons+✨
5. ✨+offer+sugges=ons+✨

12. use$lin(ng$tools

13. Responsibili*es+of+the+reviewer
1. understand+the+change
2. keep+code+compliant
3. find+bugs
4. ✨+ask+clarifying+ques=ons+✨
5. ✨+offer+sugges=ons+✨

14. write&tests

15. QA#your#changes

16. Recap:'authors
1.#give#context
2.#make#small#changes
3.#use#lin*ng#tools
4.#write#tests
5.#QA#your#changes

18. Authors

20. say$how$done$you$are

21. ask$for$specific$feedback

22. get$feedback$early$and$o0en

23. but$don't$work$too$far$upstream

24. get$a$micro+yes

25. welcome'ques+ons

26. Recap:'authors
1.#say#how#done#you#are
2.#ask#for#specific#feedback
3.#get#feedback#early#and#o2en
4.#but#don't#work#too#far#upstream
5.#get#a#micro-yes
6.#welcome#ques-ons

27. Reviewers

29. review&at&the&right&level&of&detail

30. if#the#code#is#confusing,
it's%a%problem%with%the%code
...or$an$opportunity$to$learn!

31. beta%test'your'feedback

32. communicate*the*why,
not$the$how

33. Recap:'reviewers
1.#review#at#the#right#level#of#detail
2.#if#the#code#is#confusing,#it's#a#problem#with#the#code
...or$an$opportunity$to$learn!
3.#beta(test#your#feedback
4.#communicate#the#why,#not#the#how

34. receive&be(er&reviews
become&a&be(er&reviewer
get$more$value$out$of$code$review

35. Thanks!
Julia&Evans
Kamal%Marhubi
Sasha%Laundy
Tania%Luna
A.#Jesse#Jiryu#Davis

36. Thank&you!
Amy$Hanlon
@amygdalama

37. Resources(&(Related(Reading
• Death'to'the'Rubber'Stamp'(or:'ques4ons'I'ask'myself'when'
reviewing)'h@p://mathamy.com/deathEtoEtheErubberEstamp.html
• The'Gentle'Art'of'Patch'Review'h@p://sarah.thesharps.us/
2014/09/01/theEgentleEartEofEpatchEreview/
• Your'Brain's'API:'Giving'and'GeRng'Technical'Help'h@p://
blog.sashalaundy.com/talks/askingEhelping/
• Rebecca's'Rules'for'Contruc4ve'Code'Reviews'h@ps://
storify.com/ReBeccaOrg/rebeccaEsErulesEforEconstruc4veEcodeE

38. Photos
h"p://media.wizards.com/images/magic/daily/li/li102_mindRot.jpg
h"p://www.magic=ville.com/fr/carteart?ref=cmd056
h/p://archive.wizards.com/mtg/images/daily/boab/
boab85iugh576f8ghadsd.jpg
h"p://getwallpapers.net/magic=the=gathering=artwork=mtg=jason=
chan=wallpaper=33527/
h"p://teresenielsen.typepad.com/.a/
6a00e54fd89cec88340147e233f3ca970b=500wi