Here are the slides of the code review kata given by Manuel at Open World Forum 2013. The exercice of code review is a key element to improve quality, to enable team members understanding and to share knowledge. Complementary to the pair-programming promoted by XP, code review is usually the unique case for distributed teams to make a real collaborative work on code. Gerrit is a tool for code review, based on Git. It comes from the Android project but, now, it is widely adopted by other free software communities (LibreOffice, Mediawiki, Eclipse, ...) as well as by large companies (Sony Mobile, Ericsson, SAP, Google, ...). In this session, we propose to understand how a good tool is essential for code review and how the couple GIT/Gerrit enables development teams to improve the quality of code.

1. CODE REVIEW KATA WITH
GERRIT/
© Enalean, 2013
This work is licensed under a .
Manuel Vacelet @vaceletm
Creative Commons Attribution-ShareAlike 3.0 Unported License

2. BIO / CONTEXT
Enalean CTO & developerTuleap

3. WHY TO REVIEW CODE?

4. WHERE IT COMES FROM?
Well known practice in FLOSS world
Various strategy: patches (LKML), "pull requests", ...

5. GERRIT
Comes from Android project
Git only
users: Eclipse, QT, Mediawiki, Sony, Motorola, Google,
SAP, ...
http://code.google.com/p/gerrit/

6. GERRIT WORKFLOW

7. REVIEWS DASHBOARD

8. ONE REVIEW

10. PATCH

12. DIFF, COMMENTS

14. PUSH FOR REVIEW
One commit == One review
Shape your commits (history rewriting!)
git push ssh://vaceletm@gerrit.tuleap.net:29418 HEAD:refs/for/master

15. COMMITS: SIZE MATTERS
Beware The Big One
Difficult to grasp it
Tiny not better whatsoever

16. SHAPE YOUR COMMITS!

17. GOOD PRACTICES
Reduce the wait list
Define review rules
Damn fast Continuous Integration

18. ACCESS CONTROL

20. CONCLUSION
Powerful
High learning curve
@Enalean: highest dev ROI this year

21. QUESTIONS?

22. CREDITS
It's all about feedback - code review as a great tool in the
agile toolbox
Scaling Up JGit
Deploying Gerrit Code Review